Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate service nested object params #1451

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Validate service nested object params #1451

merged 2 commits into from
Nov 1, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Oct 30, 2019 •
edited
Loading

close #1088

@krhubert krhubert added bug Something isn't working enhancement New feature or request labels Oct 30, 2019
@krhubert krhubert added this to the next milestone Oct 30, 2019
@krhubert krhubert self-assigned this Oct 30, 2019
@NicolasMahe
Copy link
Member

Can you add unit test for this function?
Will be perfect if you can add unit test on all the functions of service/validator/validator.go. There is none for now..

@krhubert
Copy link
Contributor Author

No, I don't want to add that for two reasons:

  • I just want to keep this PR as small as possible

and what's more important:

  • validation needs a bit of refactoring first so I can add the good unit tests.

Based on that we can open PR about refactor + add unit test if we want to.

@antho1404 antho1404 merged commit 1e4d7ba into dev Nov 1, 2019
@antho1404 antho1404 deleted the fix/service-validator branch November 1, 2019 09:32
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Nov 26, 2019
@NicolasMahe NicolasMahe mentioned this pull request Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@krhubert krhubert

Labels
bug Something isn't working enhancement New feature or request release:add Pull requests that add something
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Add back validation on service struct
3 participants
@krhubert @NicolasMahe @antho1404